Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remoting/use maven mirror #8638

Closed
wants to merge 6 commits into from

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Nov 16, 2019

Point RBE at a mirror of maven central.

This avoids us DDOSing maven central and getting HTTP errors as a result.

Includes logic to use this mirror inside tests.

Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# If you set remote-specific ivy/coursier options here, set them there as well.

[ivy]
bootstrap_jar_url: %(maven_central_mirror_ivy_bootstrap_jar_url)s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be able to remove the bootstrap_jar_url overrides once #8637 lands.

# can't access the real options inside tests, and plumbing these through everywhere
# they're needed is prohibitive. So we repeat the logic here.
maven_central_mirror_root_url = 'https://maven-central.storage-download.googleapis.com/repos/central/data'
maven_central_mirror_ivy_bootstrap_jar_url = f'{maven_central_mirror_root_url}/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@benjyw
Copy link
Contributor Author

benjyw commented Nov 18, 2019

Closed in favor of #8637 and #8647

@benjyw benjyw closed this Nov 18, 2019
@benjyw benjyw deleted the remoting/use-maven-mirror branch July 15, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants