-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remoting/use maven mirror #8638
Conversation
This avoids us DDOSing maven central and getting HTTP errors as a result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
# If you set remote-specific ivy/coursier options here, set them there as well. | ||
|
||
[ivy] | ||
bootstrap_jar_url: %(maven_central_mirror_ivy_bootstrap_jar_url)s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to remove the bootstrap_jar_url
overrides once #8637 lands.
# can't access the real options inside tests, and plumbing these through everywhere | ||
# they're needed is prohibitive. So we repeat the logic here. | ||
maven_central_mirror_root_url = 'https://maven-central.storage-download.googleapis.com/repos/central/data' | ||
maven_central_mirror_ivy_bootstrap_jar_url = f'{maven_central_mirror_root_url}/org/apache/ivy/ivy/2.4.0/ivy-2.4.0.jar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
89b6575
to
09b5f83
Compare
Point RBE at a mirror of maven central.
This avoids us DDOSing maven central and getting HTTP errors as a result.
Includes logic to use this mirror inside tests.